Skip to content

ci(frontend-deploy): name what is being deployed - #8431

Open
talissoncosta wants to merge 2 commits into
mainfrom
feat/deploy-card-pr-title
Open

talissoncosta wants to merge 2 commits into
mainfrom
feat/deploy-card-pr-title

Conversation

@talissoncosta

@talissoncosta talissoncosta commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

The deploy cards identify a deploy by short sha, which tells you nothing about what is in it. This adds the pull request title under the headline, linked to the pull request.

No API call and no extra permission. A squash merge puts the title and number in the first line of the commit message as title (#123), and all forty of the last forty commits on main match that shape. A direct push or a merge commit will not, so the number is optional: the title then falls back to the whole first line, unlinked, rather than producing a broken link.

The title goes full width as a context block rather than into the field grid, which is two narrow columns and would wrap a real title badly.

Deploying

image

Deployed

image

How did you test this code?

The parsing, against five commit message shapes:

commit message title link
refactor(styles): diff view and code theme on shared tokens (#8069) title without the number /pull/8069
chore: a direct push with no pull request whole line none
squash title plus a multi-line body first line only /pull/8420
empty none, line omitted none
fix: mentions (#123) mid-sentence and ends plainly whole line none, correctly not treated as a reference

That last case is why the pattern is anchored to the end of the line.

The rendering, across all four states with and without a title, confirming the context block appears only when there is one and the block order is otherwise unchanged:

in_progress  no-title: header>section>section>actions   with-title: header>context>section>section>actions
success      no-title: header>section>section>actions   with-title: header>context>section>section>actions
cancelled    no-title: header>section>section>actions   with-title: header>context>section>section>actions
failure      no-title: header>section>section>actions   with-title: header>context>section>section>actions

Both files parse as YAML. Not exercised end to end, since this workflow only runs on push to main. The steps are continue-on-error: true, so nothing here can hold up or fail a deploy.

The cards identified a deploy by short sha, which says nothing about what is
in it. Adds the pull request title under the headline, linked to the pull
request.

No API call is needed. A squash merge puts the title and number in the first
line of the commit message, as "title (#123)", and all of the last forty
commits on main match that. A direct push or a merge commit will not, so the
number is optional and the title falls back to the whole line unlinked.

The title goes full width as a context line rather than into the field grid,
which is two narrow columns and would wrap a real title badly.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
docs Ignored Ignored Preview Sep 11, 2026 4:38pm UTC
flagsmith-frontend-preview Ignored Ignored Preview Sep 11, 2026 4:38pm UTC
flagsmith-frontend-staging Ignored Ignored Preview Sep 11, 2026 4:38pm UTC

Request Review

@github-actions github-actions Bot added the ci-cd Build, test and deployment related label Sep 1, 2026
@codecov

codecov Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.82%. Comparing base (894bfa4) to head (9394181).
⚠️ Report is 54 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #8431    +/-   ##
========================================
  Coverage   98.81%   98.82%            
========================================
  Files        1621     1622     +1     
  Lines       66118    66727   +609     
========================================
+ Hits        65334    65942   +608     
- Misses        784      785     +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@talissoncosta talissoncosta reopened this Sep 9, 2026
@github-actions github-actions Bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Sep 9, 2026
@talissoncosta
talissoncosta marked this pull request as ready for review September 10, 2026 22:13
@talissoncosta
talissoncosta requested a review from a team as a code owner September 10, 2026 22:13
@talissoncosta
talissoncosta requested review from Zaimwa9 and emyller and removed request for a team September 10, 2026 22:13
@github-actions github-actions Bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Sep 10, 2026
@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

📝 Walkthrough

Walkthrough

The notification action now accepts repository and commit-message inputs. It derives a pull-request title and URL from the first commit-message line. The Slack payload conditionally displays the escaped title as a link or plain text. Both production deployment notification jobs provide the new inputs.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: 🟡 Moderate · up to 93941

Long commit subjects can suppress deployment notifications, and commit-title text can create unintended Slack links. Bound the title and disable automatic parsing before merging.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-8431 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-8431 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-8431 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-8431 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-8431 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8431 Finished ✅ Results ✅

@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-16 — run #20400 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  49.2 seconds
commit  9394181
info  🔄 Run: #20400 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20400 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  1 minute, 13 seconds
commit  9394181
info  🔄 Run: #20400 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #20400 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  45.7 seconds
commit  9394181
info  🔄 Run: #20400 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #20400 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  35.3 seconds
commit  9394181
info  🔄 Run: #20400 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20355 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  1 minute, 13 seconds
commit  8d853f9
info  🔄 Run: #20355 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #20355 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  10.6 seconds
commit  8d853f9
info  🔄 Run: #20355 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #20355 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  45 seconds
commit  8d853f9
info  🔄 Run: #20355 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #20355 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  33.5 seconds
commit  8d853f9
info  🔄 Run: #20355 (attempt 1)

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 6ca7e52f-1f9f-4d93-9a26-c6f410cedb40

📥 Commits

Reviewing files that changed from the base of the PR and between c3e1dad and 8d853f9.

📒 Files selected for processing (3)
  • .github/actions/notify-slack-deploy/action.yml
  • .github/actions/notify-slack-deploy/payload.jq
  • .github/workflows/frontend-deploy-production.yml

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Comment thread .github/actions/notify-slack-deploy/payload.jq Outdated
@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

The title comes from the deployed commit subject, so it is the only free-form
string in the card. A pull request titled "<!channel> ship it" would have
pinged the whole channel on merge, and "<url|text>" would have rendered as a
disguised link.

Escapes the three characters Slack parses, ampersand first so the entities the
other two produce are not re-encoded.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Sep 11, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 4fc8ad10-98e4-40e9-9c81-dbd55da672bf

📥 Commits

Reviewing files that changed from the base of the PR and between 8d853f9 and 9394181.

📒 Files selected for processing (1)
  • .github/actions/notify-slack-deploy/payload.jq

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Comment thread .github/actions/notify-slack-deploy/payload.jq

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd Build, test and deployment related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant